Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 17 Nov 2011 13:31:24 +0100
From: Szabolcs Nagy <>
Subject: Re: unneeded mremap calls in realloc

* Rich Felker <> [2011-11-17 00:02:53 -0500]:

> On Wed, Nov 16, 2011 at 01:45:37AM +0100, Szabolcs Nagy wrote:
> > (there might be better fix, eg why oldlen is not a
> > multiple of pagesize in the first place?)
> oldlen was computed in terms of CHUNK_SIZE macro, which was incorrect
> for mmapped chunks (masking off too many bits). should be fixed now.
> Rich

btw in realloc there is this comment:

        /* FIXME: find what's wrong here and reenable it..? */
        if (0 && n > n1 && alloc_rev(self)) {
                self = PREV_CHUNK(self);
                n1 += CHUNK_SIZE(self);

can it be that the CHUNK_SIZE fix solves this as well?

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.