Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 26 Sep 2011 19:07:34 +0200
From: Szabolcs Nagy <>
Subject: Re: minor fixes

a pedantic ctype macro fix: move the unsigned cast inside

i can think of one case where it matters:
if EOF was defined as INT_MIN then
(unsigned)(a - 'c') can overflow while ((unsigned)a - 'c') is ok

(i know this is pathological and EOF is actually defined as -1)

View attachment "ctype_cast.diff" of type "text/x-diff" (799 bytes)

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.