Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 7 Jun 2011 11:08:49 +0200
From: Igmar Palsenberg <igmar@...senberg.com>
To: musl@...ts.openwall.com
Subject: Re: Cleanup patches



> a superfluous type cast is not OK even if it's a NOOP
> it's ugly, dangerous and surprising
> 
> in this case the cast hides an important warning:
> wchar_t of musl and the compiler is different
> the solution is to define wchar_t properly
> 
> it seems pcc and gcc defines __WCHAR_TYPE__
> if clang has it defined as well then i guess musl can use it
> and fall back to int when it's not defined

Indeed.. I was bluntly assuming all compilers use the same type. I'll see if I can fix it the proper way.



	Igmar

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.