[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110606171317.GN6142@port70.net>
Date: Mon, 6 Jun 2011 19:13:18 +0200
From: Szabolcs Nagy <nsz@...t70.net>
To: musl@...ts.openwall.com
Subject: Re: Cleanup patches
* Igmar Palsenberg <igmar@...senberg.com> [2011-06-06 17:40:35 +0200]:
> See attached patches for a clang cleanup. No functional changes, just making sure it compiles without warnings.
>
--- a/Makefile
+++ b/Makefile
@@ -63,7 +63,7 @@ include/bits/alltypes.h: include/bits/alltypes.h.sh
sh $< > $@
%.o: $(ARCH)/%.s
- $(CC) $(CFLAGS) $(INC) -c -o $@ $<
+ $(CC) -c -o $@ $<
this could be $(AS) -o $@ $<
--- a/src/malloc/malloc.c
+++ b/src/malloc/malloc.c
@@ -16,9 +16,9 @@ void *__mremap(void *, size_t, size_t, int, ...);
int __madvise(void *, size_t, int);
struct chunk {
- size_t data[1];
struct chunk *next;
struct chunk *prev;
+ size_t data[];
};
this does not seem to be correct
c->data[-1] now means something different
--- a/src/regex/regcomp.c
+++ b/src/regex/regcomp.c
@@ -1845,13 +1845,12 @@ tre_add_tags(tre_mem_t mem, tre_stack_t *stack, tre_ast_node_t *tree,
case ADDTAGS_AFTER_ITERATION:
{
- int enter_tag;
node = tre_stack_pop(stack);
if (first_pass)
node->num_tags = ((tre_iteration_t *)node->obj)->arg->num_tags
+ (int)tre_stack_pop(stack);
else
- enter_tag = (int)tre_stack_pop(stack);
+ (int)tre_stack_pop(stack);
the (int) cast can go as well..
--- a/src/stdio/vfwprintf.c
+++ b/src/stdio/vfwprintf.c
@@ -185,7 +185,7 @@ static int wprintf_core(FILE *f, const wchar_t *fmt, va_list *ap, union arg *nl_
/* Handle literal text and %% format specifiers */
for (a=s; *s && *s!='%'; s++);
- litpct = wcsspn(s, L"%")/2; /* Optimize %%%% runs */
+ litpct = wcsspn(s, (wchar_t *)L"%")/2; /* Optimize %%%% runs */
z = s+litpct;
s += 2*litpct;
l = z-a;
this seems wrong
L"" is already a wchar_t string literal
and wcsspn arguments must be const qualified
Subject: [PATCH 6/6] You can't weak alias a static function or variable
you can, at least gcc/ld allows it, it just does not make much sense
but the solution is bad, polluting the public namespace is not ok
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
