[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110606220915.GF191@brightrain.aerifal.cx>
Date: Mon, 6 Jun 2011 18:09:15 -0400
From: Rich Felker <dalias@...ifal.cx>
To: musl@...ts.openwall.com
Subject: Re: Cleanup patches
On Mon, Jun 06, 2011 at 05:40:35PM +0200, Igmar Palsenberg wrote:
> diff --git a/include/dirent.h b/include/dirent.h
> index ca000bd..5496be3 100644
> --- a/include/dirent.h
> +++ b/include/dirent.h
> @@ -18,7 +18,7 @@ struct dirent
> off_t d_off;
> unsigned short d_reclen;
> unsigned char d_type;
> - char d_name[1];
> + char d_name[];
> };
Fixed in a different way that also gives better glibc
abi-compatibility.
> +++ b/src/malloc/malloc.c
> @@ -16,9 +16,9 @@ void *__mremap(void *, size_t, size_t, int, ...);
> int __madvise(void *, size_t, int);
>
> struct chunk {
> - size_t data[1];
> struct chunk *next;
> struct chunk *prev;
> + size_t data[];
> };
This is plain wrong but if needed I can adjust the code to avoid array
bounds issues.
Rich
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
