Date: Thu, 4 Jun 2020 16:27:29 +0200 From: Adam Zabrocki <pi3@....com.pl> To: lkrg-users@...ts.openwall.com Subject: Re: Support for 5.7 linux kernel? Hi, On Thu, Jun 04, 2020 at 12:37:21PM +0200, Solar Designer wrote: > On Thu, Jun 04, 2020 at 07:51:51AM +0200, Adam Zabrocki wrote: > > Can you double check if you have enabled CONFIG_MODULE_UNLOAD ? > > I've checked the sources here (latest 5.7): > > > > https://elixir.bootlin.com/linux/v5.7-rc7/source/include/linux/module.h#L501 > > > > and missing variable is under #ifdef CONFIG_MODULE_UNLOAD block. > > Maybe we need to support LKRG build without CONFIG_MODULE_UNLOAD, by > conditionally excluding the corresponding functionality from LKRG as > well. Adam, what do you think? > In theory we can, however I haven't seen any kernel in the production which allows to dynamically load kernel module but disabled CONFIG_MODULE_UNLOAD. There are significant side effects of having kernel like this and the way how kernel enumerates such modules is also slightly different. I think we should add to the code verification if specific CONFIG_* options are enabled. In such case, people would immediately see which options they are missing. I might create patch for that. Thanks, Adam > Alexander -- pi3 (pi3ki31ny) - pi3 (at) itsec pl http://pi3.com.pl
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.