Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 14 Jan 2022 14:28:25 +0100
From: Florian Weimer <>
To: "Andy Lutomirski" <>
Cc:,  "Linux API" <>,,,,  "the arch/x86 maintainers" <>,,  "Dave Hansen via Libc-alpha"
 <>,  "Linux Kernel Mailing List"
 <>,  "Dave Hansen" <>,
  "Kees Cook" <>,  "Andrei Vagin" <>
Subject: Re: [PATCH v3 2/3] selftests/x86/Makefile: Support per-target
 $(LIBS) configuration

* Andy Lutomirski:

> On Thu, Jan 13, 2022, at 2:00 PM, Florian Weimer wrote:
>> * Andy Lutomirski:
>>> On 1/5/22 08:03, Florian Weimer wrote:
>>>> And avoid compiling PCHs by accident.
>>> The patch seems fine, but I can't make heads or tails of the
>>> $SUBJECT. Can you help me?
>> What about this?
>> selftests/x86/Makefile: Set linked libraries using $(LIBS)
>> I guess that it's possible to use make features to set this per target
>> isn't important.
> I think that's actually important -- it's nice to explain to make
> dummies (e.g. me) what the purpose is is.  I assume it's so that a
> given test can override the libraries.  Also, you've conflated two
> different changes into one patch: removal of .h and addition of LIBS.

Do you want me to split this further into two commits?

  selftests/x86/Makefile: Per-target configuration of linked libraries

  Targets can set $(LIBS) to specify a different set of libraries than the
  defaults (or no libraries at all).


  selftests/x86/Makefile: Do not pass header files as compiler inputs

  Filtering out .h files avoids accidentally creating a precompiled

I didn't want to game commit metrics.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.