[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 2 Oct 2021 14:31:32 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: Alexander Popov <alex.popov@...ux.com>, Jonathan Corbet
<corbet@....net>, Paul McKenney <paulmck@...nel.org>, Andrew Morton
<akpm@...ux-foundation.org>, Thomas Gleixner <tglx@...utronix.de>, Peter
Zijlstra <peterz@...radead.org>, Joerg Roedel <jroedel@...e.de>, Maciej
Rozycki <macro@...am.me.uk>, Muchun Song <songmuchun@...edance.com>, Viresh
Kumar <viresh.kumar@...aro.org>, Robin Murphy <robin.murphy@....com>, Randy
Dunlap <rdunlap@...radead.org>, Lu Baolu <baolu.lu@...ux.intel.com>, Petr
Mladek <pmladek@...e.com>, Kees Cook <keescook@...omium.org>, Luis
Chamberlain <mcgrof@...nel.org>, Wei Liu <wl@....org>, John Ogness
<john.ogness@...utronix.de>, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com>, Alexey Kardashevskiy <aik@...abs.ru>,
Christophe Leroy <christophe.leroy@...roup.eu>, Jann Horn
<jannh@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Mark
Rutland <mark.rutland@....com>, Andy Lutomirski <luto@...nel.org>, Dave
Hansen <dave.hansen@...ux.intel.com>, Thomas Garnier <thgarnie@...gle.com>,
Will Deacon <will.deacon@....com>, Ard Biesheuvel
<ard.biesheuvel@...aro.org>, Laura Abbott <labbott@...hat.com>, David S
Miller <davem@...emloft.net>, Borislav Petkov <bp@...en8.de>,
kernel-hardening@...ts.openwall.com, linux-hardening@...r.kernel.org,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, notify@...nel.org
Subject: Re: [PATCH] Introduce the pkill_on_warn boot parameter
On Sat, 2 Oct 2021 18:04:10 +0000
Al Viro <viro@...iv.linux.org.uk> wrote:
> > @@ -610,6 +611,9 @@ void __warn(const char *file, int line, void *caller, unsigned taint,
> >
> > print_oops_end_marker();
> >
> > + if (pkill_on_warn && system_state >= SYSTEM_RUNNING)
> > + do_group_exit(SIGKILL);
> > +
>
> Wait a sec... do_group_exit() is very much not locking-neutral.
> Aren't you introducing a bunch of potential deadlocks by adding
> that?
Perhaps add an irq_work() here to trigger the do_group_exit() from a
"safe" interrupt context?
-- Steve
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
