Date: Sat, 2 Oct 2021 09:52:49 -0700 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Alexander Popov <alex.popov@...ux.com> Cc: Petr Mladek <pmladek@...e.com>, "Paul E. McKenney" <paulmck@...nel.org>, Jonathan Corbet <corbet@....net>, Andrew Morton <akpm@...ux-foundation.org>, Thomas Gleixner <tglx@...utronix.de>, Peter Zijlstra <peterz@...radead.org>, Joerg Roedel <jroedel@...e.de>, Maciej Rozycki <macro@...am.me.uk>, Muchun Song <songmuchun@...edance.com>, Viresh Kumar <viresh.kumar@...aro.org>, Robin Murphy <robin.murphy@....com>, Randy Dunlap <rdunlap@...radead.org>, Lu Baolu <baolu.lu@...ux.intel.com>, Kees Cook <keescook@...omium.org>, Luis Chamberlain <mcgrof@...nel.org>, Wei Liu <wl@....org>, John Ogness <john.ogness@...utronix.de>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Alexey Kardashevskiy <aik@...abs.ru>, Christophe Leroy <christophe.leroy@...roup.eu>, Jann Horn <jannh@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Mark Rutland <mark.rutland@....com>, Andy Lutomirski <luto@...nel.org>, Dave Hansen <dave.hansen@...ux.intel.com>, Steven Rostedt <rostedt@...dmis.org>, Will Deacon <will.deacon@....com>, David S Miller <davem@...emloft.net>, Borislav Petkov <bp@...en8.de>, Kernel Hardening <kernel-hardening@...ts.openwall.com>, linux-hardening@...r.kernel.org, "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, notify@...nel.org Subject: Re: [PATCH] Introduce the pkill_on_warn boot parameter On Sat, Oct 2, 2021 at 4:41 AM Alexander Popov <alex.popov@...ux.com> wrote: > > And what do you think about the proposed pkill_on_warn? Honestly, I don't see the point. If you can reliably trigger the WARN_ON some way, you can probably cause more problems by fooling some other process to trigger it. And if it's unintentional, then what does the signal help? So rather than a "rationale" that makes little sense, I'd like to hear of an actual _use_ case. That's different. That's somebody actually _using_ that pkill to good effect for some particular load. That said, I don't much care in the end. But it sounds like a pointless option to just introduce yet another behavior to something that should never happen anyway, and where the actual honest-to-goodness reason for WARN_ON() existing is already being fulfilled (ie syzbot has been very effective at flushing things like that out). Linus
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.