Date: Tue, 4 May 2021 17:30:23 -0700 From: Rick Edgecombe <rick.p.edgecombe@...el.com> To: dave.hansen@...el.com, luto@...nel.org, peterz@...radead.org, linux-mm@...ck.org, x86@...nel.org, akpm@...ux-foundation.org, linux-hardening@...r.kernel.org, kernel-hardening@...ts.openwall.com Cc: ira.weiny@...el.com, rppt@...nel.org, dan.j.williams@...el.com, linux-kernel@...r.kernel.org, Rick Edgecombe <rick.p.edgecombe@...el.com> Subject: [PATCH RFC 0/9] PKS write protected page tables This is a POC for write protecting page tables with PKS (Protection Keys for Supervisor) . The basic idea is to make the page tables read only, except temporarily on a per-cpu basis when they need to be modified. I’m looking for opinions on whether people like the general direction of this in terms of value and implementation. Why would people want this? =========================== Page tables are the basis for many types of protections and as such, are a juicy target for attackers. Mapping them read-only will make them harder to use in attacks. This protects against an attacker that has acquired the ability to write to the page tables. It's not foolproof because an attacker who can execute arbitrary code can either disable PKS directly, or simply call the same functions that the kernel uses for legitimate page table writes. Why use PKS for this? ===================== PKS is an upcoming CPU feature that allows supervisor virtual memory permissions to be changed without flushing the TLB, like PKU does for user memory. Protecting page tables would normally be really expensive because you would have to do it with paging itself. PKS helps by providing a way to toggle the writability of the page tables with just a per-cpu MSR. Performance impacts =================== Setting direct map permissions on whatever random page gets allocated for a page table would result in a lot of kernel range shootdowns and direct map large page shattering. So the way the PKS page table memory is created is similar to this module page clustering series, where a cache of pages is replenished from 2MB pages such that the direct map permissions and associated breakage is localized on the direct map. In the PKS page tables case, a PKS key is pre-applied to the direct map for pages in the cache. There would be some costs of memory overhead in order to protect the direct map page tables. There would also be some extra kernel range shootdowns to replenish the cache on occasion, from setting the PKS key on the direct map of the new pages. I don’t have any actual performance data yet. This is based on V6  of the core PKS infrastructure patches. PKS infrastructure follow-on’s are planned to enable keys to be set to the same permissions globally. Since this usage needs a key to be set globally read-only by default, a small temporary solution is hacked up in patch 8. Long term, PKS protected page tables would use a better and more generic solution to achieve this.  https://email@example.com/  https://firstname.lastname@example.org / Thanks, Rick Rick Edgecombe (9): list: Support getting most recent element in list_lru list: Support list head not in object for list_lru x86/mm/cpa: Add grouped page allocations mm: Explicitly zero page table lock ptr x86, mm: Use cache of page tables x86/mm/cpa: Add set_memory_pks() x86/mm/cpa: Add perm callbacks to grouped pages x86, mm: Protect page tables with PKS x86, cpa: PKS protect direct map page tables arch/x86/boot/compressed/ident_map_64.c | 5 + arch/x86/include/asm/pgalloc.h | 6 + arch/x86/include/asm/pgtable.h | 26 +- arch/x86/include/asm/pgtable_64.h | 33 ++- arch/x86/include/asm/pkeys_common.h | 8 +- arch/x86/include/asm/set_memory.h | 23 ++ arch/x86/mm/init.c | 40 +++ arch/x86/mm/pat/set_memory.c | 312 +++++++++++++++++++++++- arch/x86/mm/pgtable.c | 144 ++++++++++- include/asm-generic/pgalloc.h | 42 +++- include/linux/list_lru.h | 26 ++ include/linux/mm.h | 7 + mm/Kconfig | 6 +- mm/list_lru.c | 38 ++- mm/memory.c | 1 + mm/swap.c | 7 + mm/swap_state.c | 6 + 17 files changed, 705 insertions(+), 25 deletions(-) -- 2.30.2
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.