Date: Fri, 5 Feb 2021 08:51:35 -0800 From: Casey Schaufler <casey@...aufler-ca.com> To: "Serge E. Hallyn" <serge@...lyn.com>, Mickaël Salaün <mic@...ikod.net> Cc: James Morris <jmorris@...ei.org>, Jann Horn <jannh@...gle.com>, Al Viro <viro@...iv.linux.org.uk>, Andrew Morton <akpm@...ux-foundation.org>, Andy Lutomirski <luto@...capital.net>, Anton Ivanov <anton.ivanov@...bridgegreys.com>, Arnd Bergmann <arnd@...db.de>, Jeff Dike <jdike@...toit.com>, Jonathan Corbet <corbet@....net>, Kees Cook <keescook@...omium.org>, Michael Kerrisk <mtk.manpages@...il.com>, Richard Weinberger <richard@....at>, Shuah Khan <shuah@...nel.org>, Vincent Dagonneau <vincent.dagonneau@....gouv.fr>, kernel-hardening@...ts.openwall.com, linux-api@...r.kernel.org, linux-arch@...r.kernel.org, linux-doc@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, linux-security-module@...r.kernel.org, x86@...nel.org, John Johansen <john.johansen@...onical.com>, Mickaël Salaün <mic@...ux.microsoft.com>, Stephen Smalley <stephen.smalley.work@...il.com>, Casey Schaufler <casey@...aufler-ca.com> Subject: Re: [PATCH v28 05/12] LSM: Infrastructure management of the superblock On 2/5/2021 6:17 AM, Serge E. Hallyn wrote: > On Tue, Feb 02, 2021 at 05:27:03PM +0100, Mickaël Salaün wrote: >> From: Casey Schaufler <casey@...aufler-ca.com> >> >> Move management of the superblock->sb_security blob out of the >> individual security modules and into the security infrastructure. >> Instead of allocating the blobs from within the modules, the modules >> tell the infrastructure how much space is required, and the space is >> allocated there. >> >> Cc: Kees Cook <keescook@...omium.org> >> Cc: John Johansen <john.johansen@...onical.com> >> Signed-off-by: Casey Schaufler <casey@...aufler-ca.com> >> Signed-off-by: Mickaël Salaün <mic@...ux.microsoft.com> >> Reviewed-by: Stephen Smalley <stephen.smalley.work@...il.com> > Acked-by: Serge Hallyn <serge@...lyn.com> > > I wonder how many out of tree modules this will impact :) There are several blobs that have already been converted to infrastructure management. Not a peep from out-of-tree module developers/maintainers. I can only speculate that OOT modules are either less common than we may think, using alternative data management models (as does eBPF) or sticking with very old kernels. It's also possible that they're suffering in silence, which would be sad because every module that's worth having should be in the tree. > Actually > if some new incoming module does an rcu callback to free the > sb_security, then the security_sb_free will need an update, but > that seems unlikely. We're already doing that for the inode blob, so it's really just a small matter of cut-n-paste and s/inode/sb/ to make that happen.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.