[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 13 Nov 2020 18:49:11 -0600
From: Josh Poimboeuf <jpoimboe@...hat.com>
To: Sami Tolvanen <samitolvanen@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Jann Horn <jannh@...gle.com>,
the arch/x86 maintainers <x86@...nel.org>,
Masahiro Yamada <masahiroy@...nel.org>,
Steven Rostedt <rostedt@...dmis.org>, Will Deacon <will@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Paul E. McKenney" <paulmck@...nel.org>,
Kees Cook <keescook@...omium.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
clang-built-linux <clang-built-linux@...glegroups.com>,
Kernel Hardening <kernel-hardening@...ts.openwall.com>,
linux-arch <linux-arch@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
linux-kbuild <linux-kbuild@...r.kernel.org>,
kernel list <linux-kernel@...r.kernel.org>,
linux-pci@...r.kernel.org
Subject: Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps
On Fri, Nov 13, 2020 at 03:31:34PM -0800, Sami Tolvanen wrote:
> > #else /* !CONFIG_STACK_VALIDATION */
> > @@ -123,6 +129,8 @@ struct unwind_hint {
> > .macro UNWIND_HINT sp_reg:req sp_offset=0 type:req end=0
> > .endm
> > #endif
> > +.macro STACK_FRAME_NON_STANDARD func:req
> > +.endm
>
> This macro needs to be before the #endif, so it's defined only for
> assembly code. This breaks my arm64 builds even though x86 curiously
> worked just fine.
Yeah, I noticed that after syncing objtool.h with the tools copy. Fixed
now.
I've got fixes for some of the other warnings, but I'll queue them up
and post when they're all ready.
--
Josh
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
