kernel-hardening - Re: [PATCH v2] firewire: Remove function callback casts

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 22 May 2020 19:43:08 +0200
From: Oscar Carter <oscar.carter@....com>
To: Takashi Sakamoto <o-takashi@...amocchi.jp>
Cc: Oscar Carter <oscar.carter@....com>, Kees Cook <keescook@...omium.org>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Clemens Ladisch <clemens@...isch.de>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	kernel-hardening@...ts.openwall.com,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org, alsa-devel@...a-project.org,
	"Lev R . Oshvang ." <levonshe@...il.com>
Subject: Re: [PATCH v2] firewire: Remove function callback casts

Hi,

On Wed, May 20, 2020 at 03:16:24PM +0900, Takashi Sakamoto wrote:
> Hi,
>
> I'm an author of ALSA firewire stack and thanks for the patch. I agree with
> your intention to remove the cast of function callback toward CFI build.
>
> Practically, the isochronous context with FW_ISO_CONTEXT_RECEIVE_MULTICHANNEL
> is never used by in-kernel drivers. Here, I propose to leave current
> kernel API (fw_iso_context_create() with fw_iso_callback_t) as is.
> Alternatively, a new kernel API for the context (e.g.
> fw_iso_mc_context_create() with fw_iso_mc_callback_t). This idea leaves
> current drivers as is and the change is done inner firewire-core driver,
> therefore existent kernel API is not changed.
>
It sounds good to me.

> Later I post two patches for the proposal. I'd like you to review it and
> I'm glad to receive your comments.
>
I will take a look at your proposal. Thanks for your time and work.
>
> Regards
>
> Takashi Sakamoto

Thanks,
Oscar Carter

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.