Date: Tue, 3 Mar 2020 10:55:14 +0100 From: Peter Zijlstra <peterz@...radead.org> To: Kees Cook <keescook@...omium.org> Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Thomas Garnier <thgarnie@...omium.org>, kernel-hardening@...ts.openwall.com, kristen@...ux.intel.com, Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org, Andy Lutomirski <luto@...nel.org>, Juergen Gross <jgross@...e.com>, Thomas Hellstrom <thellstrom@...are.com>, "VMware, Inc." <pv-drivers@...are.com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>, Rasmus Villemoes <linux@...musvillemoes.dk>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Will Deacon <will@...nel.org>, Ard Biesheuvel <ardb@...nel.org>, Masami Hiramatsu <mhiramat@...nel.org>, Jiri Slaby <jslaby@...e.cz>, Boris Ostrovsky <boris.ostrovsky@...cle.com>, Josh Poimboeuf <jpoimboe@...hat.com>, Cao jin <caoj.fnst@...fujitsu.com>, Allison Randal <allison@...utok.net>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, linux-pm@...r.kernel.org Subject: Re: [PATCH v11 00/11] x86: PIE support to extend KASLR randomization On Mon, Mar 02, 2020 at 09:02:15PM -0800, Kees Cook wrote: > On Thu, Feb 27, 2020 at 04:00:45PM -0800, Thomas Garnier wrote: > > Minor changes based on feedback and rebase from v10. > > > > Splitting the previous serie in two. This part contains assembly code > > changes required for PIE but without any direct dependencies with the > > rest of the patchset. > > > > Note: Using objtool to detect non-compliant PIE relocations is not yet > > possible as this patchset only includes the simplest PIE changes. > > Additional changes are needed in kvm, xen and percpu code. > > > > Changes: > > - patch v11 (assembly); > > - Fix comments on x86/entry/64. > > - Remove KASLR PIE explanation on all commits. > > - Add note on objtool not being possible at this stage of the patchset. > > This moves us closer to PIE in a clean first step. I think these patches > look good to go, and unblock the work in kvm, xen, and percpu code. Can > one of the x86 maintainers pick this series up? But,... do we still need this in the light of that fine-grained kaslr stuff? What is the actual value of this PIE crud in the face of that?
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.