Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 12 Feb 2020 19:47:28 +0000
From: Al Viro <>
To: Linus Torvalds <>
Cc: "Eric W. Biederman" <>,
	LKML <>,
	Kernel Hardening <>,
	Linux API <>,
	Linux FS Devel <>,
	Linux Security Module <>,
	Akinobu Mita <>,
	Alexey Dobriyan <>,
	Andrew Morton <>,
	Andy Lutomirski <>,
	Daniel Micay <>,
	Djalal Harouni <>,
	"Dmitry V . Levin" <>,
	Greg Kroah-Hartman <>,
	Ingo Molnar <>,
	"J . Bruce Fields" <>,
	Jeff Layton <>,
	Jonathan Corbet <>, Kees Cook <>,
	Oleg Nesterov <>,
	Solar Designer <>
Subject: Re: [PATCH v8 07/11] proc: flush task dcache entries from all procfs

On Wed, Feb 12, 2020 at 10:45:06AM -0800, Linus Torvalds wrote:
> On Wed, Feb 12, 2020 at 7:01 AM Eric W. Biederman <> wrote:
> >
> > Fundamentally proc_flush_task is an optimization.  Just getting rid of
> > dentries earlier.  At least at one point it was an important
> > optimization because the old process dentries would just sit around
> > doing nothing for anyone.
> I'm pretty sure it's still important. It's very easy to generate a
> _ton_ of dentries with /proc.
> > I wonder if instead of invalidating specific dentries we could instead
> > fire wake up a shrinker and point it at one or more instances of proc.
> It shouldn't be the dentries themselves that are a freeing problem.
> They're being RCU-free'd anyway because of lookup. It's the
> proc_mounts list that is the problem, isn't it?
> So it's just fs_info that needs to be rcu-delayed because it contains
> that list. Or is there something else?

Large part of the headache is the possibility that some joker has
done something like mounting tmpfs on /proc/<pid>/map_files, or
binding /dev/null on top of /proc/<pid>/syscall, etc.

IOW, that d_invalidate() can very well have to grab namespace_sem.
And possibly do a full-blown fs shutdown of something NFS-mounted,

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.