Date: Fri, 15 Nov 2019 12:19:20 -0800 From: Sami Tolvanen <samitolvanen@...gle.com> To: Mark Rutland <mark.rutland@....com> Cc: Will Deacon <will@...nel.org>, Catalin Marinas <catalin.marinas@....com>, Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, Ard Biesheuvel <ard.biesheuvel@...aro.org>, Dave Martin <Dave.Martin@....com>, Kees Cook <keescook@...omium.org>, Laura Abbott <labbott@...hat.com>, Marc Zyngier <maz@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Jann Horn <jannh@...gle.com>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Masahiro Yamada <yamada.masahiro@...ionext.com>, clang-built-linux <clang-built-linux@...glegroups.com>, Kernel Hardening <kernel-hardening@...ts.openwall.com>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v5 14/14] arm64: implement Shadow Call Stack On Fri, Nov 15, 2019 at 7:20 AM Mark Rutland <mark.rutland@....com> wrote: > > On Tue, Nov 05, 2019 at 03:56:08PM -0800, Sami Tolvanen wrote: > > This change implements shadow stack switching, initial SCS set-up, > > and interrupt shadow stacks for arm64. > > Each CPU also has an overflow stack, and two SDEI stacks, which should > presumably be given their own SCS. SDEI is effectively a software-NMI, > so it should almost certainly have the same treatement as IRQ. Makes sense. I'll take a look at adding shadow stacks for the SDEI handler. > Can we please fold this comment into the one above, and have: > > /* > * The callee-saved regs (x19-x29) should be preserved between > * irq_stack_entry and irq_stack_exit. > */ > .macro irq_stack_exit > mov sp, x19 > #ifdef CONFIG_SHADOW_CALL_STACK > mov x18, x20 > #endif > .endm Sure, I'll change this in the next version. Sami
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.