Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 04 Nov 2019 14:39:34 +0109
From: Marc Zyngier <>
To: Sami Tolvanen <>
Cc: Will Deacon <>, Catalin Marinas
 <>, Steven Rostedt <>, Masami
 Hiramatsu <>, Ard Biesheuvel <>,
 Dave Martin <>, Kees Cook <>, Laura
 Abbott <>, Mark Rutland <>, Nick
 Desaulniers <>, Jann Horn <>, Miguel
 Ojeda <>, Masahiro Yamada
 <>, <>,
 <>, <>
Subject: Re: [PATCH v4 03/17] arm64: kvm: stop treating register x18 as  caller save

On 2019-11-04 12:13, Marc Zyngier wrote:
> Hi Sami,
> On 2019-11-01 23:20, Sami Tolvanen wrote:
>> From: Ard Biesheuvel <>
>> In preparation of reserving x18, stop treating it as caller save in
>> the KVM guest entry/exit code. Currently, the code assumes there is
>> no need to preserve it for the host, given that it would have been
>> assumed clobbered anyway by the function call to __guest_enter().
>> Instead, preserve its value and restore it upon return.
>> Link:
>> Signed-off-by: Ard Biesheuvel <>
>> [Sami: updated commit message, switched from x18 to x29 for the 
>> guest
>> context]
>> Signed-off-by: Sami Tolvanen <>
>> Reviewed-by: Kees Cook <>
> If you intend for this to be merged via the arm64 tree, please add my
> Reviewed-by: Marc Zyngier <>

Erm... Muscle memory strikes again. Please ignore the above and use the
following instead:

Reviewed-by: Marc Zyngier <>


Jazz is not dead. It just smells funny...

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.