[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 24 Oct 2019 21:42:59 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: Sami Tolvanen <samitolvanen@...gle.com>, Will Deacon <will@...nel.org>,
Catalin Marinas <catalin.marinas@....com>, Masami Hiramatsu
<mhiramat@...nel.org>, Ard Biesheuvel <ard.biesheuvel@...aro.org>, Dave
Martin <Dave.Martin@....com>, Kees Cook <keescook@...omium.org>, Laura
Abbott <labbott@...hat.com>, Mark Rutland <mark.rutland@....com>, Nick
Desaulniers <ndesaulniers@...gle.com>, Jann Horn <jannh@...gle.com>, Miguel
Ojeda <miguel.ojeda.sandonis@...il.com>, clang-built-linux
<clang-built-linux@...glegroups.com>, Kernel Hardening
<kernel-hardening@...ts.openwall.com>, linux-arm-kernel
<linux-arm-kernel@...ts.infradead.org>, Linux Kernel Mailing List
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 16/17] arm64: disable SCS for hypervisor code
On Fri, 25 Oct 2019 10:29:47 +0900
Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
> On Fri, Oct 25, 2019 at 7:52 AM <samitolvanen@...gle.com> wrote:
> >
> > Signed-off-by: Sami Tolvanen <samitolvanen@...gle.com>
> > ---
> > arch/arm64/kvm/hyp/Makefile | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile
> > index ea710f674cb6..8289ea086e5e 100644
> > --- a/arch/arm64/kvm/hyp/Makefile
> > +++ b/arch/arm64/kvm/hyp/Makefile
> > @@ -28,3 +28,6 @@ GCOV_PROFILE := n
> > KASAN_SANITIZE := n
> > UBSAN_SANITIZE := n
> > KCOV_INSTRUMENT := n
> > +
> > +ORIG_CFLAGS := $(KBUILD_CFLAGS)
> > +KBUILD_CFLAGS = $(subst $(CC_FLAGS_SCS),,$(ORIG_CFLAGS))
>
>
> $(subst ... ) is not the correct use here.
>
> It works like sed, s/$(CC_CFLAGS_SCS)//
> instead of matching by word.
>
>
>
>
> KBUILD_CFLAGS := $(filter-out $(CC_FLAGS_SCS), $(KBUILD_CFLAGS))
>
> is more correct, and simpler.
I guess that would work too. Not sure why I never used it. I see mips
used it for their -pg flags.
-- Steve
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
