Date: Tue, 22 Oct 2019 16:47:08 +0100 From: Mark Rutland <mark.rutland@....com> To: Sami Tolvanen <samitolvanen@...gle.com> Cc: Will Deacon <will@...nel.org>, Catalin Marinas <catalin.marinas@....com>, Steven Rostedt <rostedt@...dmis.org>, Ard Biesheuvel <ard.biesheuvel@...aro.org>, Dave Martin <Dave.Martin@....com>, Kees Cook <keescook@...omium.org>, Laura Abbott <labbott@...hat.com>, Nick Desaulniers <ndesaulniers@...gle.com>, clang-built-linux <clang-built-linux@...glegroups.com>, Kernel Hardening <kernel-hardening@...ts.openwall.com>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 13/18] arm64: preserve x18 when CPU is suspended On Mon, Oct 21, 2019 at 03:43:14PM -0700, Sami Tolvanen wrote: > On Mon, Oct 21, 2019 at 9:56 AM Mark Rutland <mark.rutland@....com> wrote: > > This should have a corresponding change to cpu_suspend_ctx in > > <asm/suspend.h>. Otherwise we're corrupting a portion of the stack. > > Ugh, correct. I'll fix this in the next version. Thanks. It's probably worth extending the comment above cpu_do_suspend to say: | This must be kept in sync with struct cpu_suspend_ctx in | <asm/suspend.h> ... to match what we have above struct cpu_suspend_ctx, and make this more obvious in future. Thanks, Mark.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.