[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sat, 5 Oct 2019 02:45:27 +0800
From: kbuild test robot <lkp@...el.com>
To: Alexander Potapenko <glider@...gle.com>
Cc: kbuild-all@...org, Andrew Morton <akpm@...ux-foundation.org>,
Christoph Lameter <cl@...ux.com>,
Alexander Potapenko <glider@...gle.com>,
Thibaut Sautereau <thibaut@...tereau.fr>,
Kees Cook <keescook@...omium.org>,
Laura Abbott <labbott@...hat.com>, linux-mm@...ck.org,
kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH v1 1/2] mm: slub: init_on_free=1 should wipe freelist ptr
for bulk allocations
Hi Alexander,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mmotm/master]
url: https://github.com/0day-ci/linux/commits/Alexander-Potapenko/mm-slub-init_on_free-1-should-wipe-freelist-ptr-for-bulk-allocations/20191005-012134
base: git://git.cmpxchg.org/linux-mmotm.git master
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> mm/slub.c:2676:24: warning: return type defaults to 'int' [-Wreturn-type]
static __always_inline maybe_wipe_obj_freeptr(struct kmem_cache *s, void *obj)
^~~~~~~~~~~~~~~~~~~~~~
mm/slub.c: In function 'maybe_wipe_obj_freeptr':
>> mm/slub.c:2680:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
vim +/int +2676 mm/slub.c
2671
2672 /*
2673 * If the object has been wiped upon free, make sure it's fully initialized by
2674 * zeroing out freelist pointer.
2675 */
> 2676 static __always_inline maybe_wipe_obj_freeptr(struct kmem_cache *s, void *obj)
2677 {
2678 if (unlikely(slab_want_init_on_free(s)) && obj)
2679 memset((void *)((char *)obj + s->offset), 0, sizeof(void *));
> 2680 }
2681
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (59039 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
