[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 30 Sep 2019 15:46:29 -0700
From: Kees Cook <keescook@...omium.org>
To: Romain Perier <romain.perier@...il.com>
Cc: kernel-hardening@...ts.openwall.com
Subject: Re: [PRE-REVIEW PATCH 11/16] treewide: Globally replace
tasklet_init() by tasklet_setup()
On Sun, Sep 29, 2019 at 06:30:23PM +0200, Romain Perier wrote:
> This converts all remaining cases of the old tasklet_init() API into
> tasklet_setup(), where the callback argument is the structure already
> holding the struct tasklet_struct. These should have no behavioral changes,
> since they just change which pointer is passed into the callback with
> the same available pointers after conversion. Moreover, all callbacks
> that were not passing a pointer of structure holding the struct
> tasklet_struct has already been converted.
Was this done mechanically with Coccinelle or manually? (If done with
Coccinelle, please include the script in the commit log.) To land a
treewide change like this usually you'll need to separate the mechanical
from the manual as Linus likes to run those changes himself sometimes.
--
Kees Cook
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
