Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 26 Sep 2019 15:10:05 -0700
From: Kees Cook <>
To: Tianlin Li <>
Subject: Re: Introduction and get involved

On Thu, Sep 26, 2019 at 09:57:58AM -0500, Tianlin Li wrote:
> > On Sep 24, 2019, at 6:12 PM, Kees Cook <> wrote:
> > I've been keeping a (rather terse) TODO list here:
> >
> > 
> > But I'd like to turn that into an actual bug list on github or the like.

I've (slowly) started this process now:

> > I wonder if working on something like this:
> > - set_memory_*() needs __must_check and/or atomicity
> > would be interesting?
> > 
> > The idea there is that set_memory_*() calls can fail, so callers should
> > likely be handling errors correctly. Adding the "__must_check" attribute
> > and fixing all the callers would be nice (and certainly touches the
> > memory management code!)
> This is a great starting task for me. So for this task, basically I need to add __must_check attribute to set_memory_*() functions and fix all the callers to make sure they check the return values. Do I understand correctly?

Yup, that's right. I've added that issue with some more details now:

> Also I have some other questions:
> Is there any requirement for the patches? e.g. based on which kernel version? how many individual patches?

I recommend basing your patches on either the last full release (v5.3
currently) or, if you need something newer, on the -rc2 of the next
release (v5.4-rc2). We are, however, in the middle of the merge window,
so -rc2 doesn't exist yet. :)

The general details on submitting patches apply:

Feel free to post "RFC" patches here to this list first if you want some
initial feedback. (Though I recommend still including maintainers in Cc
to get their feedback too.)

Kees Cook

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.