Date: Thu, 8 Aug 2019 17:47:29 +0200 From: Romain Perier <romain.perier@...il.com> To: Kees Cook <keescook@...omium.org> Cc: Kernel Hardening <kernel-hardening@...ts.openwall.com>, Shyam Saini <mayhs11saini@...il.com> Subject: Re: refactor tasklets to avoid unsigned long argument Hi ! Work is in progress (that's an hobby not full time). I am testing the build with "allyesconfig". Do you think it is acceptable to change drivers/mmc/host/renesas_sdhi_internal_dmac.c to add a pointer to the "struct device" or to the "host", so renesas_sdhi_internal_dmac_complete_tasklet_fn() could access "host" from the tasklet parameter because currently, it is not possible. from the tasklet you can access "dma_priv", from "dma_priv" you can access "priv", then from "priv", you're blocked :) This is what I have done for now : https://salsa.debian.org/rperier-guest/linux-tree/commit/a0e5735129b4118a1df55b02fead6fa9b7996520 (separately) Then the handler would be something like: https://salsa.debian.org/rperier-guest/linux-tree/commit/5fe1eaeb45060a7df10d166cc96e0bdcf0024368 (scroll down to renesas_sdhi_internal_dmac_complete_tasklet_fn() ). What do you think ? Regards, Romain Le mar. 23 juil. 2019 à 10:15, Romain Perier <romain.perier@...il.com> a écrit : > > Le lun. 22 juil. 2019 à 19:19, Kees Cook <keescook@...omium.org> a écrit : > > > > On Sun, Jul 21, 2019 at 07:55:33PM +0200, Romain Perier wrote: > > > Ok, thanks for these explanations. > > > > (Reminder: please use inline-context email replies instead of > > top-posting, this makes threads much easier to read.) > > Arf, good point. My bad :) > > > > > > > Looks good! I wonder if you're able to use Coccinelle to generate the > > conversion patch? There appear to be just under 400 callers of > > tasklet_init(), which is a lot to type by hand. :) > > Mmmhhh, I did not thought *at all* to coccinelle for this, good idea. > I am gonna to read some docs about the tool > > > > > Also, have you found any other tasklet users that are NOT using > > tasklet_init()? The timer_struct conversion had about three ways > > to do initialization. :( > > This is what I was looking before you give me details about the task. > It seems, there > is only one way to init a tasklet. I have just re-checked, it seems ok. > > Thanks for your feedbacks, > Regards, > Romain
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.