|
Message-ID: <d2e0d1e5-cf6d-1c82-bae6-60e34f651cc1@huawei.com> Date: Thu, 8 Aug 2019 11:32:03 +0800 From: Jason Yan <yanaijie@...wei.com> To: Michael Ellerman <mpe@...erman.id.au>, <linuxppc-dev@...ts.ozlabs.org>, <diana.craciun@....com>, <christophe.leroy@....fr>, <benh@...nel.crashing.org>, <paulus@...ba.org>, <npiggin@...il.com>, <keescook@...omium.org>, <kernel-hardening@...ts.openwall.com> CC: <linux-kernel@...r.kernel.org>, <wangkefeng.wang@...wei.com>, <yebin10@...wei.com>, <thunder.leizhen@...wei.com>, <jingxiangfeng@...wei.com>, <fanchengyang@...wei.com>, <zhaohongjiang@...wei.com> Subject: Re: [PATCH v5 02/10] powerpc: move memstart_addr and kernstart_addr to init-common.c On 2019/8/7 21:02, Michael Ellerman wrote: > Jason Yan <yanaijie@...wei.com> writes: >> These two variables are both defined in init_32.c and init_64.c. Move >> them to init-common.c. >> >> Signed-off-by: Jason Yan <yanaijie@...wei.com> >> Cc: Diana Craciun <diana.craciun@....com> >> Cc: Michael Ellerman <mpe@...erman.id.au> >> Cc: Christophe Leroy <christophe.leroy@....fr> >> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org> >> Cc: Paul Mackerras <paulus@...ba.org> >> Cc: Nicholas Piggin <npiggin@...il.com> >> Cc: Kees Cook <keescook@...omium.org> >> Reviewed-by: Christophe Leroy <christophe.leroy@....fr> >> Reviewed-by: Diana Craciun <diana.craciun@....com> >> Tested-by: Diana Craciun <diana.craciun@....com> >> --- >> arch/powerpc/mm/init-common.c | 5 +++++ >> arch/powerpc/mm/init_32.c | 5 ----- >> arch/powerpc/mm/init_64.c | 5 ----- >> 3 files changed, 5 insertions(+), 10 deletions(-) >> >> diff --git a/arch/powerpc/mm/init-common.c b/arch/powerpc/mm/init-common.c >> index a84da92920f7..152ae0d21435 100644 >> --- a/arch/powerpc/mm/init-common.c >> +++ b/arch/powerpc/mm/init-common.c >> @@ -21,6 +21,11 @@ >> #include <asm/pgtable.h> >> #include <asm/kup.h> >> >> +phys_addr_t memstart_addr = (phys_addr_t)~0ull; >> +EXPORT_SYMBOL_GPL(memstart_addr); >> +phys_addr_t kernstart_addr; >> +EXPORT_SYMBOL_GPL(kernstart_addr); > > Would be nice if these can be __ro_after_init ? > Good idea. > cheers > > . >
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.