Date: Mon, 5 Aug 2019 09:54:44 -0700 From: Kees Cook <keescook@...omium.org> To: Borislav Petkov <bp@...en8.de> Cc: Thomas Garnier <thgarnie@...omium.org>, kernel-hardening@...ts.openwall.com, kristen@...ux.intel.com, Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v9 01/11] x86/crypto: Adapt assembly for PIE support On Mon, Aug 05, 2019 at 06:32:02PM +0200, Borislav Petkov wrote: > On Tue, Jul 30, 2019 at 12:12:45PM -0700, Thomas Garnier wrote: > > Change the assembly code to use only relative references of symbols for the > > kernel to be PIE compatible. > > > > Position Independent Executable (PIE) support will allow to extend the > > KASLR randomization range below 0xffffffff80000000. > > I believe in previous reviews I asked about why this sentence is being > replicated in every commit message and now it is still in every commit > message except in 2/11. > > Why do you need it everywhere and not once in the 0th mail? I think there was some long-ago feedback from someone (Ingo?) about giving context for the patch so looking at one individually would let someone know that it was part of a larger series. This is a distant memory, though. Do you think it should just be dropped in each patch? -- Kees Cook
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.