Date: Mon, 22 Jul 2019 15:24:33 -0700 From: Joe Perches <joe@...ches.com> To: Jonathan Corbet <corbet@....net> Cc: Stephen Kitt <steve@....org>, Kees Cook <keescook@...omium.org>, Nitin Gote <nitin.r.gote@...el.com>, jannh@...gle.com, kernel-hardening@...ts.openwall.com, linux-kernel@...r.kernel.org, Rasmus Villemoes <rasmus.villemoes@...vas.dk> Subject: Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). On Mon, 2019-07-22 at 15:57 -0600, Jonathan Corbet wrote: > On Mon, 22 Jul 2019 14:50:09 -0700 > Joe Perches <joe@...ches.com> wrote: > > > On Mon, 2019-07-22 at 23:01 +0200, Stephen Kitt wrote: > > > How about you submit your current patch set, and I follow up with the above > > > adapted to stracpy? > > > > OK, I will shortly after I figure out how to add kernel-doc > > for stracpy/stracpy_pad to lib/string.c. > > > > It doesn't seem appropriate to add the kernel-doc to string.h > > as it would be separated from the others in string.c > > > > Anyone got a clue here? Jonathan? > > If the functions themselves are fully defined in the .h file, I'd just add > the kerneldoc there as well. That's how it's usually done, and you want > to keep the documentation and the prototypes together. In this case, it's a macro and yes, the kernel-doc could easily be set around the macro in the .h, but my desire is to keep all the string function kernel-doc output together so it should be added to lib/string.c Are you suggesting I move all the lib/string.c kernel-doc to include/linux/string.h ?
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.