[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 22 Jul 2019 10:40:58 -0700
From: Joe Perches <joe@...ches.com>
To: Kees Cook <keescook@...omium.org>, NitinGote <nitin.r.gote@...el.com>
Cc: corbet@....net, akpm@...ux-foundation.org, apw@...onical.com,
linux-doc@...r.kernel.org, kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH v5] Documentation/checkpatch: Prefer strscpy/strscpy_pad
over strcpy/strlcpy/strncpy
On Mon, 2019-07-22 at 10:30 -0700, Kees Cook wrote:
> On Wed, Jul 17, 2019 at 10:00:05AM +0530, NitinGote wrote:
> > From: Nitin Gote <nitin.r.gote@...el.com>
> >
> > Added check in checkpatch.pl to
> > 1. Deprecate strcpy() in favor of strscpy().
> > 2. Deprecate strlcpy() in favor of strscpy().
> > 3. Deprecate strncpy() in favor of strscpy() or strscpy_pad().
> >
> > Updated strncpy() section in Documentation/process/deprecated.rst
> > to cover strscpy_pad() case.
> >
> > Signed-off-by: Nitin Gote <nitin.r.gote@...el.com>
>
> Reviewed-by: Kees Cook <keescook@...omium.org>
>
> Joe, does this address your checkpatch concerns?
Well, kinda.
strscpy_pad isn't used anywhere in the kernel.
And
+ "strncpy" => "strscpy, strscpy_pad or for non-NUL-terminated strings, strncpy() can still be used, but destinations should be marked with __nonstring",
is a bit verbose. This could be simply:
+ "strncpy" => "strscpy - for non-NUL-terminated uses, strncpy() dst should be __nonstring",
And I still prefer adding stracpy as it
reduces code verbosity and eliminates defects.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
