Date: Fri, 17 May 2019 15:37:14 +0200 From: Alexander Potapenko <glider@...gle.com> To: Michal Hocko <mhocko@...nel.org> Cc: Kees Cook <keescook@...omium.org>, Andrew Morton <akpm@...ux-foundation.org>, Christoph Lameter <cl@...ux.com>, Kernel Hardening <kernel-hardening@...ts.openwall.com>, Masahiro Yamada <yamada.masahiro@...ionext.com>, James Morris <jmorris@...ei.org>, "Serge E. Hallyn" <serge@...lyn.com>, Nick Desaulniers <ndesaulniers@...gle.com>, Kostya Serebryany <kcc@...gle.com>, Dmitry Vyukov <dvyukov@...gle.com>, Sandeep Patil <sspatil@...roid.com>, Laura Abbott <labbott@...hat.com>, Randy Dunlap <rdunlap@...radead.org>, Jann Horn <jannh@...gle.com>, Mark Rutland <mark.rutland@....com>, Souptick Joarder <jrdr.linux@...il.com>, Matthew Wilcox <willy@...radead.org>, Linux Memory Management List <linux-mm@...ck.org>, linux-security-module <linux-security-module@...r.kernel.org> Subject: Re: [PATCH v2 3/4] gfp: mm: introduce __GFP_NO_AUTOINIT On Fri, May 17, 2019 at 3:25 PM Michal Hocko <mhocko@...nel.org> wrote: > > On Fri 17-05-19 15:18:19, Alexander Potapenko wrote: > > On Fri, May 17, 2019 at 2:59 PM Michal this flag Hocko > > <mhocko@...nel.org> wrote: > > > > > > [It would be great to keep people involved in the previous version in the > > > CC list] > > Yes, I've been trying to keep everyone in the loop, but your email > > fell through the cracks. > > Sorry about that. > > No problem > > > > On Tue 14-05-19 16:35:36, Alexander Potapenko wrote: > > > > When passed to an allocator (either pagealloc or SL[AOU]B), > > > > __GFP_NO_AUTOINIT tells it to not initialize the requested memory if the > > > > init_on_alloc boot option is enabled. This can be useful in the cases > > > > newly allocated memory is going to be initialized by the caller right > > > > away. > > > > > > > > __GFP_NO_AUTOINIT doesn't affect init_on_free behavior, except for SLOB, > > > > where init_on_free implies init_on_alloc. > > > > > > > > __GFP_NO_AUTOINIT basically defeats the hardening against information > > > > leaks provided by init_on_alloc, so one should use it with caution. > > > > > > > > This patch also adds __GFP_NO_AUTOINIT to alloc_pages() calls in SL[AOU]B. > > > > Doing so is safe, because the heap allocators initialize the pages they > > > > receive before passing memory to the callers. > > > > > > I still do not like the idea of a new gfp flag as explained in the > > > previous email. People will simply use it incorectly or arbitrarily. > > > We have that juicy experience from the past. > > > > Just to preserve some context, here's the previous email: > > https://patchwork.kernel.org/patch/10907595/ > > (plus the patch removing GFP_TEMPORARY for the curious ones: > > https://lwn.net/Articles/729145/) > > Not only. GFP_REPEAT being another one and probably others I cannot > remember from the top of my head. > > > > Freeing a memory is an opt-in feature and the slab allocator can already > > > tell many (with constructor or GFP_ZERO) do not need it. > > Sorry, I didn't understand this piece. Could you please elaborate? > > The allocator can assume that caches with a constructor will initialize > the object so additional zeroying is not needed. GFP_ZERO should be self > explanatory. Ah, I see. We already do that, see the want_init_on_alloc() implementation here: https://patchwork.kernel.org/patch/10943087/ > > > So can we go without this gfp thing and see whether somebody actually > > > finds a performance problem with the feature enabled and think about > > > what can we do about it rather than add this maint. nightmare from the > > > very beginning? > > > > There were two reasons to introduce this flag initially. > > The first was double initialization of pages allocated for SLUB. > > Could you elaborate please? When the kernel allocates an object from SLUB, and SLUB happens to be short on free pages, it requests some from the page allocator. Those pages are initialized by the page allocator and split into objects. Finally SLUB initializes one of the available objects and returns it back to the kernel. Therefore the object is initialized twice for the first time (when it comes directly from the page allocator). This cost is however amortized by SLUB reusing the object after it's been freed. > > However the benchmark results provided in this and the previous patch > > don't show any noticeable difference - most certainly because the cost > > of initializing the page is amortized. > > > The second one was to fine-tune hackbench, for which the slowdown > > drops by a factor of 2. > > But optimizing a mitigation for certain benchmarks is a questionable > > measure, so maybe we could really go without it. > > Agreed. Over optimization based on an artificial workloads tend to be > dubious IMHO. > > -- > Michal Hocko > SUSE Labs -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.