Date: Wed, 8 May 2019 21:36:06 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Eric Biggers <ebiggers@...nel.org> Cc: Kees Cook <keescook@...omium.org>, Joao Moreira <jmoreira@...e.de>, Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>, X86 ML <x86@...nel.org>, linux-crypto <linux-crypto@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Kernel Hardening <kernel-hardening@...ts.openwall.com> Subject: Re: [PATCH v3 0/7] crypto: x86: Fix indirect function call casts On Tue, May 07, 2019 at 02:50:46PM -0700, Eric Biggers wrote: > > I don't know yet. It's difficult to read the code with 2 layers of macros. > > Hence why I asked why you didn't just change the prototypes to be compatible. I agree. Kees, since you're changing this anyway please make it look better not worse. Thanks, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.