Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 23 Apr 2019 12:17:33 -0700
From: Kees Cook <>
To: Alexander Potapenko <>
Cc: Andrew Morton <>, Christoph Lameter <>, 
	Dmitry Vyukov <>, Laura Abbott <>, Linux-MM <>, 
	linux-security-module <>, 
	Kernel Hardening <>
Subject: Re: [PATCH 3/3] RFC: net: apply __GFP_NOINIT to AF_UNIX sk_buff allocations

On Thu, Apr 18, 2019 at 8:42 AM Alexander Potapenko <> wrote:
> Add sock_alloc_send_pskb_noinit(), which is similar to
> sock_alloc_send_pskb(), but allocates with __GFP_NOINIT.
> This helps reduce the slowdown on hackbench from 9% to 0.1%.

I would include a detailed justification about why this is safe to do.
I imagine (but haven't looked) that the skb is immediately written to
after allocation, so this is basically avoiding a "double init". Is
that correct?

Kees Cook

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.