Date: Mon, 8 Apr 2019 08:08:45 -0600 From: shuah <shuah@...nel.org> To: "Tobin C. Harding" <tobin@...nel.org> Cc: Kees Cook <keescook@...omium.org>, Jann Horn <jannh@...gle.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Randy Dunlap <rdunlap@...radead.org>, Rasmus Villemoes <linux@...musvillemoes.dk>, Stephen Rothwell <sfr@...b.auug.org.au>, Andy Lutomirski <luto@...capital.net>, Daniel Micay <danielmicay@...il.com>, Arnd Bergmann <arnd@...db.de>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, kernel-hardening@...ts.openwall.com, linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org, shuah <shuah@...nel.org> Subject: Re: [PATCH v4 0/6] lib/string: Add strscpy_pad() function On 4/4/19 7:58 PM, Tobin C. Harding wrote: > Hi Shua, > > Here is the set with cleanup as suggested by Kees on v3. > > Configured, built, and tested all modules loaded by > tools/testing/selftests/lib/*.sh > >>>From previous cover letters ... > > While doing the testing for strscpy_pad() it was noticed that there is > duplication in how test modules are being fed to kselftest and also in > the test modules themselves. > > This set makes an attempt at adding a framework to kselftest for writing > kernel test modules. It also adds a script for use in creating script > test runners for kselftest. My macro-foo is not great, all criticism > and suggestions very much appreciated. The design is based on test > modules lib/test_printf.c, lib/test_bitmap.c, lib/test_xarray.c. > > Changes since last version: > > - Remove dependency on Bash (thanks Kees) > - Use oneliner to implement kselftest test runners (thanks Kees) > - Squash patch that adds kselftest script creator script with patch > that uses it. > - Fix typos (thanks Randy) > - Add Kees' Acked-by tags to all patches > > thanks, > Tobin. > > Hi Tobin, Thanks for this restructuring work and adding the framework. Thanks Kees for the reviews. The patch is series in now in linux-kselftest next for 5.2 thanks, -- Shuah
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.