Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 25 Feb 2019 10:19:47 +0200
From: Andy Shevchenko <>
To: "Tobin C. Harding" <>
Cc: Kees Cook <>, Jann Horn <>, 
	Andy Shevchenko <>, Randy Dunlap <>, 
	Rasmus Villemoes <>, Stephen Rothwell <>, 
	Andy Lutomirski <>, Daniel Micay <>, 
	Arnd Bergmann <>, Miguel Ojeda <>, 
	"Gustavo A. R. Silva" <>, Shuah Khan <>, 
	Greg Kroah-Hartman <>, 
	Alexander Shishkin <>, 
	Kernel Hardening <>, 
	Linux Kernel Mailing List <>
Subject: Re: [PATCH v2 1/1] lib/string: Add strscpy_pad() function

On Mon, Feb 25, 2019 at 6:17 AM Tobin C. Harding <> wrote:
> We have a function to copy strings safely and we have a function to copy
> strings and zero the tail of the destination (if source string is
> shorter than destination buffer) but we do not have a function to do
> both at once.  This means developers must write this themselves if they
> desire this functionality.  This is a chore, and also leaves us open to
> off by one errors unnecessarily.
> Add a function that calls strscpy() then memset()s the tail to zero if
> the source string is shorter than the destination buffer.
> Add test module for the new code.

> --- /dev/null
> +++ b/lib/test_strscpy.c
> @@ -0,0 +1,175 @@

> +// SPDX-License-Identifier: GPL-2.0


License mismatch.

Do we need a separate module for this test?

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.