Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 11 Feb 2019 18:39:52 -0800
From: Matthew Wilcox <>
To: Igor Stoppa <>
Cc: Igor Stoppa <>,
	Andy Lutomirski <>,
	Nadav Amit <>,
	Peter Zijlstra <>,
	Kees Cook <>,
	Dave Hansen <>,
	Mimi Zohar <>,
	Thiago Jung Bauermann <>,
	Ahmed Soliman <>,,,,
Subject: Re: [RFC PATCH v4 01/12] __wr_after_init: Core and default arch

On Tue, Feb 12, 2019 at 01:27:38AM +0200, Igor Stoppa wrote:
> +#ifndef CONFIG_PRMEM
> +#else
> +
> +#include <linux/mm.h>

It's a mistake to do conditional includes like this.  That way you see
include loops with some configs and not others.  Our headers are already
so messy, better to just include mm.h unconditionally.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.