Date: Mon, 11 Feb 2019 20:09:25 +0100 From: Borislav Petkov <bp@...en8.de> To: Rick Edgecombe <rick.p.edgecombe@...el.com> Cc: Andy Lutomirski <luto@...nel.org>, Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org, x86@...nel.org, hpa@...or.com, Thomas Gleixner <tglx@...utronix.de>, Nadav Amit <nadav.amit@...il.com>, Dave Hansen <dave.hansen@...ux.intel.com>, Peter Zijlstra <peterz@...radead.org>, linux_dti@...oud.com, linux-integrity@...r.kernel.org, linux-security-module@...r.kernel.org, akpm@...ux-foundation.org, kernel-hardening@...ts.openwall.com, linux-mm@...ck.org, will.deacon@....com, ard.biesheuvel@...aro.org, kristen@...ux.intel.com, deneen.t.dock@...el.com Subject: Re: [PATCH v2 13/20] Add set_alias_ function and x86 implementation On Mon, Jan 28, 2019 at 04:34:15PM -0800, Rick Edgecombe wrote: > This adds two new functions set_alias_default_noflush and s/This adds/Add/ > set_alias_nv_noflush for setting the alias mapping for the page to its Please end function names with parentheses, below too. > default valid permissions and to an invalid state that cannot be cached in > a TLB, respectively. These functions to not flush the TLB. s/to/do/ Also, pls put that description as comments over the functions in the code. Otherwise that "nv" as part of the name doesn't really explain what it does. Actually, you could just as well call the function set_alias_invalid_noflush() All the other words are written in full, no need to have "nv" there. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.