Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 26 Oct 2018 11:38:04 +0200
From: Peter Zijlstra <>
To: Igor Stoppa <>
Cc: Mimi Zohar <>,
	Kees Cook <>,
	Matthew Wilcox <>,
	Dave Chinner <>,
	James Morris <>, Michal Hocko <>,,,,,
	Dave Hansen <>,
	Jonathan Corbet <>, Laura Abbott <>,
	Thomas Gleixner <>,
	Kate Stewart <>,
	"David S. Miller" <>,
	Greg Kroah-Hartman <>,
	Philippe Ombredanne <>,
	"Paul E. McKenney" <>,
	Josh Triplett <>,
	Steven Rostedt <>,
	Mathieu Desnoyers <>,
	Lai Jiangshan <>,
Subject: Re: [PATCH 14/17] prmem: llist, hlist, both plain and rcu

On Wed, Oct 24, 2018 at 12:35:01AM +0300, Igor Stoppa wrote:
> In some cases, all the data needing protection can be allocated from a pool
> in one go, as directly writable, then initialized and protected.
> The sequence is relatively short and it's acceptable to leave the entire
> data set unprotected.
> In other cases, this is not possible, because the data will trickle over
> a relatively long period of time, in a non predictable way, possibly for
> the entire duration of the operations.
> For these cases, the safe approach is to have the memory already write
> protected, when allocated. However, this will require replacing any
> direct assignment with calls to functions that can perform write rare.
> Since lists are one of the most commonly used data structures in kernel,
> they are a the first candidate for receiving write rare extensions.
> This patch implements basic functionality for altering said lists.
> Signed-off-by: Igor Stoppa <>
> CC: Thomas Gleixner <>
> CC: Kate Stewart <>
> CC: "David S. Miller" <>
> CC: Greg Kroah-Hartman <>
> CC: Philippe Ombredanne <>
> CC: "Paul E. McKenney" <>
> CC: Josh Triplett <>
> CC: Steven Rostedt <>
> CC: Mathieu Desnoyers <>
> CC: Lai Jiangshan <>
> CC:
> ---
>  MAINTAINERS            |   1 +
>  include/linux/prlist.h | 934 +++++++++++++++++++++++++++++++++++++++++

I'm not at all sure I understand the Changelog, or how it justifies
duplicating almost 1k lines of code.

Sure lists aren't the most complicated thing we have, but duplicating
that much is still very _very_ bad form. Why are we doing this?

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.