Date: Tue, 8 May 2018 12:32:49 +0200 From: Salvatore Mesoraca <s.mesoraca16@...il.com> To: David Laight <David.Laight@...lab.com> Cc: Florian Fainelli <f.fainelli@...il.com>, Andrew Lunn <andrew@...n.ch>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Kernel Hardening <kernel-hardening@...ts.openwall.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Kees Cook <keescook@...omium.org>, Vivien Didelot <vivien.didelot@...oirfairelinux.com> Subject: Re: [PATCH v2] net: dsa: drop some VLAs in switch.c 2018-05-08 11:39 GMT+02:00 David Laight <David.Laight@...lab.com>: > From: Salvatore Mesoraca >> Sent: 07 May 2018 20:03 > ... >> This optimization will save us an allocation when number of ports is >> less than 32 or 64 (depending on arch). >> IMHO it's useful, if you consider that, right now, DSA works only with >> 12-ports switches. > > Why not just error out if the number of ports is greater than the compile-time > limit? > > Worry about dynamic allocation if you need a lot more than 64 ports. v1 has been NAK-ed by maintainers because they don't want limits on how many ports a switch can have. Salvatore
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.