kernel-hardening - Re: [patch V3 01/10] rslib: Add GFP aware init function

Follow @Openwall on Twitter for new release announcements and other news

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 25 Apr 2018 10:59:48 +0200 (CEST)
From: Thomas Gleixner <tglx@...utronix.de>
To: Kees Cook <keescook@...omium.org>
cc: Stephen Rothwell <sfr@...b.auug.org.au>, 
    LKML <linux-kernel@...r.kernel.org>, 
    Segher Boessenkool <segher@...nel.crashing.org>, 
    Kernel Hardening <kernel-hardening@...ts.openwall.com>, 
    Andrew Morton <akpm@...uxfoundation.org>, 
    Boris Brezillon <boris.brezillon@...e-electrons.com>, 
    Richard Weinberger <richard@....at>, David Woodhouse <dwmw2@...radead.org>, 
    Alasdair Kergon <agk@...hat.com>, Mike Snitzer <snitzer@...hat.com>, 
    Anton Vorontsov <anton@...msg.org>, Colin Cross <ccross@...roid.com>, 
    Tony Luck <tony.luck@...el.com>, Neil Brown <neilb@...e.com>
Subject: Re: [patch V3 01/10] rslib: Add GFP aware init function

On Tue, 24 Apr 2018, Kees Cook wrote:
> On Tue, Apr 24, 2018 at 6:16 PM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> > On Sun, 22 Apr 2018 18:23:46 +0200 Thomas Gleixner <tglx@...utronix.de> wrote:
> >> +static inline struct rs_control *init_rs(int symsize, int gfpoly, int fcr,
> >> +                                      int prim, int nroots)
> >> +{
> >> +     return init_rs_gfp(symsize, gfpoly, fcr, prim, nroots, GFP_KERNEL);
> >> +}
> >> +
> >
> > The version of this patch that Kees has committed to his kspp tree in linux-next has
> >
> > #include <linux/slab.h>
> >
> > why not just
> >
> > #include <linux/types.h>        /* for gpf_t */
> > #include <linux/gpf.h>          /* for GFP_KERNEL */
> >
> > ?

Sure

> We could certainly switch to that. (Why doesn't gfp.h include types.h?)

Excellent question.

Thanks,

	tglx

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.