Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 20 Apr 2018 16:02:23 -0700
From: Kees Cook <>
To: Thomas Gleixner <>
Cc: LKML <>, 
	Segher Boessenkool <>, 
	Kernel Hardening <>, 
	Andrew Morton <>, 
	Boris Brezillon <>, Richard Weinberger <>, 
	David Woodhouse <>, Alasdair Kergon <>, Mike Snitzer <>, 
	Anton Vorontsov <>, Colin Cross <>, Tony Luck <>
Subject: Re: [patch V2 0/8] rslib: Cleanup and VLA removal

On Thu, Apr 19, 2018 at 3:04 AM, Thomas Gleixner <> wrote:
> Kees tried to get rid of the Variable Length Arrays in the Reed-Solomon
> library by replacing them with fixed length arrays on stack. Though they
> are rather large and Andrew did not fall in love with that solution.
> This series addresses that in a different way by splitting the rs control
> structure up, so that each invocation of rs_init() returns a new instance
> in which the decoder buffers are allocated. The polynom tables which build
> the base for the RS codecs are still shareable between the instances to
> avoid large allocations and initializations of the same data over and over.
> The usage sites have been audited and fixed up where necessary to
> accomodate the decoder change which forbids parallel decoder invocation for
> a particular rs control instance to prevent buffer corruption.
> While at it the patch set tidies up the code and converts the related files
> over to use SPDX license identifiers.
> Changes since V1:
>    Simplify error path in the diskonchip code and use the proper
>    function to free the decoder.
> As this spawns multiple subsystems it should either go through Andrews tree
> or Kees can route it with his other hardening stuff.

I can start collecting ignored VLA patches. I haven't done that yet as
most maintainers have been taking them. There are only a handful
unapplied. Should I start the tree with rslib? :)

Either way:

Reviewed-by: Kees Cook <>


Kees Cook
Pixel Security

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.