Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 8 Apr 2018 17:22:19 +0800
From: Herbert Xu <>
To: Salvatore Mesoraca <>
	Kernel Hardening <>,,
	"David S. Miller" <>,
	Kees Cook <>,
	Eric Biggers <>,
	Laura Abbott <>
Subject: Re: [PATCH 3/6] crypto: api - avoid VLA use

On Sun, Apr 08, 2018 at 11:07:12AM +0200, Salvatore Mesoraca wrote:
> > This check should be done when the algorithm is registered.  Perhaps
> > crypto_check_alg.
> Please correct me if I'm wrong:
> isn't crypto_check_alg invoked also during hashing algorithm registration?
> In this patch-set I'm dealing only with ciphers, because the maximum
> block size (16)
> is relatively small and it's also the most common block size with
> ciphers (maybe I should
> have explicitly referenced ciphers in the macro names, my bad).
> I don't think that it would be OK to use a similar approach for hashes
> too, because some
> of them have block size >= 1024 bytes.

Yes we want to make it for ciphers only even if we move it to

For a legacy type like cipher cou can do it by

	if (!alg->cra_type && (alg->cra_flags & CRYPTO_ALG_TYPE_MASK) ==

Email: Herbert Xu <>
Home Page:
PGP Key:

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.