Date: Tue, 27 Mar 2018 15:41:23 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Laura Abbott <labbott@...hat.com> Cc: Phil Reid <preid@...ctromag.com.au>, Kees Cook <keescook@...omium.org>, Patrice Chotard <patrice.chotard@...com>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, kernel-hardening@...ts.openwall.com Subject: Re: [PATCHv2 4/4] gpio: Remove VLA from stmpe driver Hi Laura, sorry for slow response :/ On Thu, Mar 22, 2018 at 10:43 PM, Laura Abbott <labbott@...hat.com> wrote: > On 03/18/2018 06:29 PM, Phil Reid wrote: >> >> On 16/03/2018 02:00, Laura Abbott wrote: >>> >>> The new challenge is to remove VLAs from the kernel >>> (see https://lkml.org/lkml/2018/3/7/621) >>> >>> This patch replaces a VLA with an appropriate call to kmalloc_array. >>> >>> Signed-off-by: Laura Abbott <labbott@...hat.com> >>> --- >>> v2: Switch to GFP_KERNEL. There was some discussion about if we should >>> be doing the allocation at all but given a) the allocation is pretty >>> small and b) we can possibly take a mutex in a called function I think >>> this is fine. >> >> >> I still think it's a bad idea. It's simple to preallocate the buffer. >> But it's up to the maintainer. >> > > I'd feel a lot more confident about doing the global buffer with > guidance from the maintainer. But looking at the platform data, the > maximum number of GPIOs is 24, or 3 banks. Maybe we should just always > stack allocate the maximum since it's fairly small. Either way works fine, global (in the state container struct stmpe_gpio) or stack allocation for 24 bits. I guess I am maintainer for this, I can test it at least. Yours, Linus Walleij
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.