Date: Mon, 26 Mar 2018 14:52:06 -1000 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Kees Cook <keescook@...omium.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, Martin Uecker <Martin.Uecker@....uni-goettingen.de>, Josh Poimboeuf <jpoimboe@...hat.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Randy Dunlap <rdunlap@...radead.org>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Ingo Molnar <mingo@...nel.org>, David Laight <David.Laight@...lab.com>, Ian Abbott <abbotti@....co.uk>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Kernel Hardening <kernel-hardening@...ts.openwall.com> Subject: Re: [PATCH v6] kernel.h: Retain constant expression output for max()/min() On Mon, Mar 26, 2018 at 12:15 PM, Kees Cook <keescook@...omium.org> wrote: > > This patch updates the min()/max() macros to evaluate to a constant > expression when called on constant expression arguments. Ack. I'm of two minds whether that "__is_constant()" macro should be explained or not. A small voice in my head says "that wants a comment". But a bigger voice disagrees. It is a work of art, and maybe the best documentation is just the name. It does what it says it does. Art shouldn't be explained. It should be appreciated. Nobody sane really should care about how it works, and if somebody cares it is "left as an exercise to the reader". Linus
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.