Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 20 Mar 2018 13:36:55 +0100
From: Pablo Neira Ayuso <>
To: "Gustavo A. R. Silva" <>
Cc: Jozsef Kadlecsik <>,
	Florian Westphal <>,
	"David S. Miller" <>,,,,,
	Kernel Hardening <>,
	Kees Cook <>,
	"Gustavo A. R. Silva" <>
Subject: Re: [PATCH] netfilter: nfnetlink_cthelper: Remove VLA usage

On Mon, Mar 12, 2018 at 07:21:38PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA and replace it
> with dynamic memory allocation.
> From a security viewpoint, the use of Variable Length Arrays can be
> a vector for stack overflow attacks. Also, in general, as the code
> evolves it is easy to lose track of how big a VLA can get. Thus, we
> can end up having segfaults that are hard to debug.
> Also, fixed as part of the directive to remove all VLAs from
> the kernel:

also applied, thanks.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.