Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Mar 2018 12:14:04 +0100
From: Krzysztof Kozlowski <>
To: "Gustavo A. R. Silva" <>
Cc: Sangbeom Kim <>, 
	Bartlomiej Zolnierkiewicz <>, Alessandro Zummo <>, 
	Alexandre Belloni <>,,,, 
	Kernel Hardening <>, Kees Cook <>, 
	"Gustavo A. R. Silva" <>
Subject: Re: [PATCH 2/2] rtc: s5m: Remove VLA usage

On Sat, Mar 10, 2018 at 7:27 AM, Gustavo A. R. Silva
<> wrote:
> In preparation to enabling -Wvla, remove VLAs and replace them
> with fixed-length arrays instead.
> From a security viewpoint, the use of Variable Length Arrays can be
> a vector for stack overflow attacks. Also, in general, as the code
> evolves it is easy to lose track of how big a VLA can get. Thus, we
> can end up having segfaults that are hard to debug.
> Also, fixed as part of the directive to remove all VLAs from
> the kernel:
> Signed-off-by: Gustavo A. R. Silva <>
> ---
>  drivers/rtc/rtc-s5m.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)

Reviewed-by: Krzysztof Kozlowski <>

Best regards,

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.