Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Mar 2018 16:46:13 +1100
From: "Tobin C. Harding" <>
To: Greg Kroah-Hartman <>,
	Eric Anholt <>,
	Stefan Wahren <>
	Tycho Andersen <>, Kees Cook <>
Subject: Re: [PATCH v2] staging: vchiq_arm: Clear VLA warning

On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrote:
> The kernel would like to have all stack VLA usage removed[1].  The array
> here is fixed (declared with a const variable) but it appears like a VLA
> to the compiler.  Also, currently we are putting 768 bytes on the
> stack.  This function is only called on the error path so performance is
> not critical, let's just allocate the memory instead of using the
> stack.  This saves stack space and removes the VLA build warning.
> kmalloc a buffer for dumping state instead of using the stack.
> [1]:
> Signed-off-by: Tobin C. Harding <>
> ---

Drop this please, leaks memory.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.