Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 12 Mar 2018 09:46:16 +1100
From: "Tobin C. Harding" <>
To: Linus Torvalds <>
Cc: Kees Cook <>,
	Andrew Morton <>,
	Linux Kernel Mailing List <>,
	Josh Poimboeuf <>,
	Rasmus Villemoes <>,
	"Gustavo A. R. Silva" <>,
	Steven Rostedt <>,	Jonathan Corbet <>,
 Chris Mason <>,	Josef Bacik <>,
 David Sterba <>,	"David S. Miller" <>,
	Alexey Kuznetsov <>,
	Hideaki YOSHIFUJI <>,
	Ingo Molnar <>,	Peter Zijlstra <>,
	Thomas Gleixner <>,
	Masahiro Yamada <>,
	Borislav Petkov <>, Randy Dunlap <>,
	Ian Abbott <>,
	Sergey Senozhatsky <>,
	Petr Mladek <>,
	Andy Shevchenko <>,
	Pantelis Antoniou <>,
	Linux Btrfs <>,
	Network Development <>,
	Kernel Hardening <>
Subject: Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in

On Fri, Mar 09, 2018 at 01:10:30PM -0800, Linus Torvalds wrote:
> On Fri, Mar 9, 2018 at 12:05 PM, Kees Cook <> wrote:
> > When max() is used in stack array size calculations from literal values
> > (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]", the compiler
> > thinks this is a dynamic calculation due to the single-eval logic, which
> > is not needed in the literal case. This change removes several accidental
> > stack VLAs from an x86 allmodconfig build:
> Ok, looks good.
> I just have a couple of questions about applying it.
> In particular, if this will help people working on getting rid of
> VLA's in the short term, I can apply it directly. But if people who
> are looking at it (anybody else than Kees?) don't much care, then this
> might be a 4.17 thing or at least "random -mm queue"?

It's easy enough to work on the other VLA removals without basing on
this, no rush.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.