Date: Fri, 9 Mar 2018 10:35:55 -0800 From: Kees Cook <keescook@...omium.org> To: Eric Anholt <eric@...olt.net> Cc: "Tobin C. Harding" <me@...in.cc>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Stefan Wahren <stefan.wahren@...e.com>, Kernel Hardening <kernel-hardening@...ts.openwall.com>, LKML <linux-kernel@...r.kernel.org>, driverdev-devel@...uxdriverproject.org, Tycho Andersen <tycho@...ho.ws> Subject: Re: [PATCH] staging: vchiq_arm: Clear VLA warning On Fri, Mar 9, 2018 at 10:11 AM, Eric Anholt <eric@...olt.net> wrote: > "Tobin C. Harding" <me@...in.cc> writes: > >> The kernel would like to have all stack VLA usage removed. The >> array here is fixed (declared with a const variable) but it appears >> like VLA to the compiler. We can use a pre-processor define to quiet >> the compiler. >> >> : https://lkml.org/lkml/2018/3/7/621 >> >> Signed-off-by: Tobin C. Harding <me@...in.cc> >> --- >> >> The name of this constant may need changing, there is already a >> pre-processor constant VCHIQ_MAX_SERVICES > > Maybe just use ARRAY_SIZE(local_max_services) and not have the #define? I think you mean ARRAY_SIZE(service_data) ? In that case, yeah, it seems like a raw "64" for the array size can be used instead. -Kees -- Kees Cook Pixel Security
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.