Date: Fri, 9 Mar 2018 05:34:36 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Andreas Christoforou <andreaschristofo@...il.com>, keescook@...omium.org Cc: kernel-hardening@...ts.openwall.com, QCA ath9k Development <ath9k-devel@....qualcomm.com>, Kalle Valo <kvalo@...eaurora.org>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage On 03/09/2018 05:23 AM, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed. > > This is the correct patch. > > Signed-off-by: Andreas Christoforou <andreaschristofo@...il.com> This is a lazy changelog really. 'This is the correct patch' has no technical value. What is VLA ? Sure, _now_ its pretty clear since we have floods of these patches, but... In one or two years, people reading it will not understand the logic of this patch. I had to look at the source to understand what was going on, and that is not a good sign for a trivial patch like that.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.