Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 08 Mar 2018 21:59:11 +0000
From: Ian Campbell <ijc@...lion.org.uk>
To: Kees Cook <keescook@...omium.org>, Andrew Morton
 <akpm@...ux-foundation.org>
Cc: Josh Poimboeuf <jpoimboe@...hat.com>, Rasmus Villemoes
 <linux@...musvillemoes.dk>, "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
  "Tobin C. Harding" <me@...in.cc>, rostedt@...dmis.org, corbet@....net,
 Chris Mason <clm@...com>,  Josef Bacik <jbacik@...com>, David Sterba
 <dsterba@...e.com>, "David S. Miller" <davem@...emloft.net>,  Alexey
 Kuznetsov <kuznet@....inr.ac.ru>, Hideaki YOSHIFUJI
 <yoshfuji@...ux-ipv6.org>, Ingo Molnar <mingo@...nel.org>,  Peter Zijlstra
 <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, Masahiro
 Yamada <yamada.masahiro@...ionext.com>, Borislav Petkov <bp@...e.de>, Randy
 Dunlap <rdunlap@...radead.org>, Ian Abbott <abbotti@....co.uk>, Sergey
 Senozhatsky <sergey.senozhatsky.work@...il.com>, Petr Mladek
 <pmladek@...e.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Pantelis Antoniou <pantelis.antoniou@...sulko.com>, 
 linux-btrfs@...r.kernel.org, netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH] kernel.h: Skip single-eval logic on literals in
 min()/max()

On Thu, 2018-03-08 at 13:40 -0800, Kees Cook wrote:
> 
> +#define __min(t1, t2, x, y)						\
> +	__builtin_choose_expr(__builtin_constant_p(x) &&		\
> +			      __builtin_constant_p(y) &&		\
> +			      __builtin_types_compatible_p(t1, t2),	\
> +			      (t1)(x) < (t2)(y) ? (t1)(x) : (t2)(y),	\
> +			      __single_eval_min(t1, t2,			\
> +						__UNIQUE_ID(max1_),	\
> +						__UNIQUE_ID(max2_),	\

min1_ etc?

Ian.

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.