Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 8 Mar 2018 13:06:33 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Josh Poimboeuf <jpoimboe@...hat.com>
Cc: Kees Cook <keescook@...omium.org>, Andrew Morton
 <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, corbet@....net,
 gustavo@...eddedor.com, Chris Mason <clm@...com>, Josef Bacik
 <jbacik@...com>, David Sterba <dsterba@...e.com>, "David S. Miller"
 <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, Hideaki
 YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Ingo Molnar <mingo@...nel.org>, Peter
 Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>,
 Masahiro Yamada <yamada.masahiro@...ionext.com>, Borislav Petkov
 <bp@...e.de>, Randy Dunlap <rdunlap@...radead.org>, Ian Abbott
 <abbotti@....co.uk>, "Tobin C. Harding" <me@...in.cc>, Sergey Senozhatsky
 <sergey.senozhatsky.work@...il.com>, Petr Mladek <pmladek@...e.com>, Andy
 Shevchenko <andriy.shevchenko@...ux.intel.com>, Pantelis Antoniou
 <pantelis.antoniou@...sulko.com>, linux-btrfs@...r.kernel.org,
 netdev@...r.kernel.org, kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH 0/3] Remove accidental VLA usage

On Thu, 8 Mar 2018 09:02:36 -0600
Josh Poimboeuf <jpoimboe@...hat.com> wrote:

> On Wed, Mar 07, 2018 at 07:30:44PM -0800, Kees Cook wrote:
> > This series adds SIMPLE_MAX() to be used in places where a stack array
> > is actually fixed, but the compiler still warns about VLA usage due to
> > confusion caused by the safety checks in the max() macro.
> > 
> > I'm sending these via -mm since that's where I've introduced SIMPLE_MAX(),
> > and they should all have no operational differences.  
> 
> What if we instead simplify the max() macro's type checking so that GCC
> can more easily fold the array size constants?  The below patch seems to
> work:

Nice. Have you tried to do a allmodconfig and build on various archs?

Of course pushing it to kernel.org will have the zero day bot do it for
you ;-)

-- Steve

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.