Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 8 Mar 2018 13:06:33 -0500
From: Steven Rostedt <>
To: Josh Poimboeuf <>
Cc: Kees Cook <>, Andrew Morton
 <>,,,, Chris Mason <>, Josef Bacik
 <>, David Sterba <>, "David S. Miller"
 <>, Alexey Kuznetsov <>, Hideaki
 YOSHIFUJI <>, Ingo Molnar <>, Peter
 Zijlstra <>, Thomas Gleixner <>,
 Masahiro Yamada <>, Borislav Petkov
 <>, Randy Dunlap <>, Ian Abbott
 <>, "Tobin C. Harding" <>, Sergey Senozhatsky
 <>, Petr Mladek <>, Andy
 Shevchenko <>, Pantelis Antoniou
Subject: Re: [PATCH 0/3] Remove accidental VLA usage

On Thu, 8 Mar 2018 09:02:36 -0600
Josh Poimboeuf <> wrote:

> On Wed, Mar 07, 2018 at 07:30:44PM -0800, Kees Cook wrote:
> > This series adds SIMPLE_MAX() to be used in places where a stack array
> > is actually fixed, but the compiler still warns about VLA usage due to
> > confusion caused by the safety checks in the max() macro.
> > 
> > I'm sending these via -mm since that's where I've introduced SIMPLE_MAX(),
> > and they should all have no operational differences.  
> What if we instead simplify the max() macro's type checking so that GCC
> can more easily fold the array size constants?  The below patch seems to
> work:

Nice. Have you tried to do a allmodconfig and build on various archs?

Of course pushing it to will have the zero day bot do it for
you ;-)

-- Steve

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.