[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 6 Mar 2018 06:13:17 -0800
From: Matthew Wilcox <willy@...radead.org>
To: Mike Rapoport <rppt@...ux.vnet.ibm.com>
Cc: Igor Stoppa <igor.stoppa@...wei.com>, david@...morbit.com,
keescook@...omium.org, mhocko@...nel.org, labbott@...hat.com,
linux-security-module@...r.kernel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com
Subject: Re: [PATCH 1/7] genalloc: track beginning of allocations
On Tue, Mar 06, 2018 at 02:19:03PM +0100, Mike Rapoport wrote:
> > +/**
> > + * gen_pool_create() - create a new special memory pool
> > + * @min_alloc_order: log base 2 of number of bytes each bitmap entry
> > + * represents
> > + * @nid: node id of the node the pool structure should be allocated on,
> > + * or -1
> > + *
> > + * Create a new special memory pool that can be used to manage special
> > + * purpose memory not managed by the regular kmalloc/kfree interface.
> > + *
> > + * Return:
> > + * * pointer to the pool - success
> > + * * NULL - otherwise
> > + */
>
> If I'm not mistaken, several kernel-doc descriptions are duplicated now.
> Can you please keep a single copy? ;-)
I think the problem is that Igor has chosen to put the kernel-doc with
the function declaration. I think we usually recommend putting it with
the definition so it's more likely to be updated.
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
